Skip to content

fix(P13): route transient Segment send-loop errors off Sentry #9420

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
eordano wants to merge 1 commit into from
Closed

fix(P13): route transient Segment send-loop errors off Sentry #9420

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 6 additions & 10 deletions Explorer/Assets/Plugins/RustSegment/SegmentServerWrap/RustSegmentAnalyticsService.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,9 +49,6 @@ private enum Operation
private long trackId;
private long flushId;

// temportal sentry budget fix. TODO remove once the core issue solved
private static bool ONCE_PATTERN_ALREADY_CAUGHT = false;

public RustSegmentAnalyticsService(string writerKey, string? anonId)
{
using Mutex<RustSegmentAnalyticsService>.Guard instanceGuard = CURRENT.Lock(); // IGNORE_LINE_WEBGL_THREAD_SAFETY_FLAG
Expand Down Expand Up @@ -234,18 +231,17 @@ private static void ErrorCallback(IntPtr msg)
string marshaled = Marshal.PtrToStringUTF8(msg) ?? "cannot parse message";
bool isCaught = marshaled.Contains(ONCE_PATTERN);

if (isCaught && ONCE_PATTERN_ALREADY_CAUGHT)
if (isCaught)
{
// Don't log if already was
// Transient, self-recovering analytics-upload failure (the SDK retries): this is
// report-noise, not a hard error. Route to the local debug log only — never Sentry —
// so it stops generating Sentry errors (UNITY-EXPLORER-P13: 637 events / 242 users).
ReportHub.LogWarning(ReportCategory.ANALYTICS, $"Segment error: {marshaled}", ReportHandler.DebugLog);
return;
}

// Genuine, non-transient Segment errors keep full Sentry reporting.
ReportHub.LogException(new Exception($"Segment error: {marshaled}"), ReportCategory.ANALYTICS);

if (isCaught)
{
ONCE_PATTERN_ALREADY_CAUGHT = true;
}
}
catch
{
Expand Down
Loading