feat(parser): implement stricter DID Core v1.0 URI parser#163
Open
rmlearney-digicatapult wants to merge 8 commits into
Open
feat(parser): implement stricter DID Core v1.0 URI parser#163rmlearney-digicatapult wants to merge 8 commits into
rmlearney-digicatapult wants to merge 8 commits into
Conversation
Signed-off-by: rmlearney-digicatapult <robert.learney@digicatapult.org.uk>
Signed-off-by: rmlearney-digicatapult <robert.learney@digicatapult.org.uk>
mirceanis
requested changes
Jul 17, 2026
mirceanis
left a comment
Member
There was a problem hiding this comment.
Hi, thank you for your submission!
I'd take a slightly different approach.
Instead of introducing strict methods, rather tighten the existing ones.
This may be a breaking change, thus needing a major version bump, but the point is for the functionality that exists here to be compatible with DID Core.
Please update the existing methods to be stricter, instead of introducing new ones.
If too many things break, we can add lenient methods after
Author
|
Hi @mirceanis happy to do that, wanted to take the lower-risk route and not force a major semver |
Signed-off-by: rmlearney-digicatapult <robert.learney@digicatapult.org.uk>
Signed-off-by: rmlearney-digicatapult <robert.learney@digicatapult.org.uk>
Signed-off-by: rmlearney-digicatapult <robert.learney@digicatapult.org.uk>
Signed-off-by: rmlearney-digicatapult <robert.learney@digicatapult.org.uk>
Signed-off-by: rmlearney-digicatapult <robert.learney@digicatapult.org.uk>
rmlearney-digicatapult
force-pushed
the
feat/parse-strict
branch
2 times, most recently
from
July 17, 2026 10:26
6e145e3 to
ac8abe4
Compare
Signed-off-by: rmlearney-digicatapult <robert.learney@digicatapult.org.uk>
rmlearney-digicatapult
force-pushed
the
feat/parse-strict
branch
from
July 17, 2026 10:27
ac8abe4 to
124beef
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Existing
parser()is more lenient thanDID Core v1.0(andv1.1) describes in§3.1&§3.2for DID syntaxUpdated
parser()to comply with stricterDID Core v1.0requirements:paramsremoved fromParsedDID)RFC 3986character sets forpath/query/fragmentGlobal and per-call caching still enabled, but not through matrix parameters (not in spec)
More flexible per-call caching now allows per-call cache control both positively and negatively even if global is disabled, when previous matrix parameter usage only allowed noCache if global was enabled. Documented in
README.mdAdded new tests for
parser()Bumped version to
6.0.0