fix(types): add type checking script and fix errors in tests#114
fix(types): add type checking script and fix errors in tests#114rmlearney-digicatapult wants to merge 6 commits into
Conversation
enforce assertionMethod negative test case for regressions use dataintegrityprooftemplate and other types more widely line enhanced witness methods and did:key handling centralise did key utilities and use in assertions count verified witness approvals Signed-off-by: rmlearney-digicatapult <robert.learney@digicatapult.org.uk>
Signed-off-by: rmlearney-digicatapult <robert.learney@digicatapult.org.uk>
Signed-off-by: rmlearney-digicatapult <robert.learney@digicatapult.org.uk>
Signed-off-by: rmlearney-digicatapult <robert.learney@digicatapult.org.uk>
Signed-off-by: rmlearney-digicatapult <robert.learney@digicatapult.org.uk>
Signed-off-by: rmlearney-digicatapult <robert.learney@digicatapult.org.uk>
rmlearney-digicatapult
force-pushed
the
fix/type-check
branch
from
d7ce769 to
fcd441e
Compare
| return parameters.witness ?? {}; | ||
| } | ||
|
|
||
| if ((parameters as any).witnesses) { |
There was a problem hiding this comment.
these (parameters as any) should probably be typed with a proper interface as well
There was a problem hiding this comment.
I've had to purposely ignore any in this first pass because there are just too many of them. I've got them cleaned up in a local branch which I'll push after sequential merges of these PRs (they all build incrementally)
|
This PR is great but appears to recreate a bunch of #113 which do we want to merge? |
Apologies, I've been building by locally forking latest developments rather than basing directly on main which means each one drags along history. The plan was to put these up to show what I'm working on, then sequentially rebase as the older PRs are merged in |
|
@rmlearney-digicatapult looks like this pr has a merge conflict. |
3 participants
First pass to enforce type safety
Implemented
bunx tsc --noEmitas package scriptFixed errors in tests with strict non-null assertions, enum comparison
Expanded
tsconfigto include scriptsNB merge after #113