chore(linter): implement Biome linter, first fixes and static tests in CI#115
Draft
rmlearney-digicatapult wants to merge 4 commits into
Draft
chore(linter): implement Biome linter, first fixes and static tests in CI#115rmlearney-digicatapult wants to merge 4 commits into
rmlearney-digicatapult wants to merge 4 commits into
Conversation
rmlearney-digicatapult
force-pushed
the
fix/linting
branch
2 times, most recently
from
518081b to
d746e5f
Compare
rmlearney-digicatapult
changed the title
Contributor
|
This PR is great but includes the functionality changes from the other PRs. Let's get them in first and then we can do this one |
Contributor
Author
|
@brianorwhatever yes apologies I've been building sequentially on top of previous PRs and pushing for visibility, with plan to rebase on each merge to clean up Will leave as |
Signed-off-by: rmlearney-digicatapult <robert.learney@digicatapult.org.uk> (cherry picked from commit aa6289a) (cherry picked from commit a729c84a61f10db27dae03a2df6270ced1a86035) Signed-off-by: rmlearney-digicatapult <robert.learney@digicatapult.org.uk>
(cherry picked from commit 1065075d3df1ce3c176977d0182d70b0909dd55e) Signed-off-by: rmlearney-digicatapult <robert.learney@digicatapult.org.uk>
Signed-off-by: rmlearney-digicatapult <robert.learney@digicatapult.org.uk> (cherry picked from commit d746e5f) (cherry picked from commit c7aff0a8ba7940f20a25fb47d5c73989d9409af4) Signed-off-by: rmlearney-digicatapult <robert.learney@digicatapult.org.uk>
Signed-off-by: rmlearney-digicatapult <robert.learney@digicatapult.org.uk> (cherry picked from commit df205b5) (cherry picked from commit f9789ffd5f9624a5acb8c9b5c8870c658d93ff27) Signed-off-by: rmlearney-digicatapult <robert.learney@digicatapult.org.uk>
rmlearney-digicatapult
force-pushed
the
fix/linting
branch
from
df205b5 to
2893bb8
Compare
Contributor
|
@rmlearney-digicatapult theres a couple failing tests and merge conflict |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Installed
Biomewith custom settings to match existing repo patterns:Different strictness levels for tests/scripts/examples versus core library
Turned off
anychecking in first pass but implemented null assertion fixes, chain operator, and cleaned up one implicitanyand one test file use ofanyIntroduced
ci.ymlto run static checks in CI