feat: add runtime-safe resolver entry disabling#548
Open
ankurdotb wants to merge 4 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add runtime support for disabling resolver driver entries by stable entry id, without changing DID-method ownership semantics and without adding a new public probing API. Disabled entries are skipped during normal resolve/dereference and omitted from
/methodsand/testIdentifiers; overlapping enabled entries continue to work.This PR keeps the deployment change limited to passing
UNIRESOLVER_DISABLED_ENTRIESintouni-resolver-webvia the generatedapp-configConfigMap. The deploy path always writes the variable, including an empty value, so a later deployment can clear a stale disabled set.docker-compose.ymlalso exposes the same empty runtime environment variable for local visibility/parity.No frontend changes are required. The deployed frontend reads
/1.0/methodsand/1.0/testIdentifiersfromuni-resolver-web, so the UI follows the backend’s enabled entry surface. This PR intentionally does not include_entryIdforced probing, probe tokens, report-only health checks, weekly status workflows, auto-disable state updates, auto-deploy, service type changes, resource limits, or pruning.Documentation
idvalues indocs/driver-development.md.disabled-entriesdeploy input and runtime behavior inci/deploy-k8s-aws/README.md.UNIRESOLVER_DISABLED_ENTRIESto theuni-resolver-webDocker Compose environment as the local runtime knob.Tests
JAVA_HOME=/tmp/jdk17/Contents/Home /tmp/apache-maven-3.9.9/bin/mvn -pl uni-resolver-web -am test -Dcodegen.skip=truebash -n ci/deploy-k8s-aws/scripts/process-env.sh ci/deploy-k8s-aws/scripts/deploy-services.shgit diff --checkruby -ryaml -e 'cfg=YAML.load_file("docker-compose.yml"); env=cfg.fetch("services").fetch("uni-resolver-web").fetch("environment"); abort("missing UNIRESOLVER_DISABLED_ENTRIES") unless env.key?("UNIRESOLVER_DISABLED_ENTRIES")'