Skip to content

fix(vtex): give the birthday matcher its own icon - #1651

Open
guitavano wants to merge 1 commit into
mainfrom
guitavano/vtex-matcher-forms
Open

fix(vtex): give the birthday matcher its own icon#1651
guitavano wants to merge 1 commit into
mainfrom
guitavano/vtex-matcher-forms

Conversation

@guitavano

@guitavano guitavano commented Jul 30, 2026

Copy link
Copy Markdown
Contributor

Summary

Changes the birthday matcher's @icon from calendar-eventgift. It previously shared the calendar icon with the generic Date matcher; a gift gives the birthday matcher its own identity in the admin's matcher picker.

Note

An earlier revision of this PR also flattened userSegment's union Props into an enum, to work around the admin not rendering discriminated unions. That's been reverted — the admin (Studio) is being fixed to render union Props as a branch selector (with the interface @titles as labels, like the legacy admin did), so userSegment keeps its nicer union-of-interfaces source. Only birthday.ts changes here now.

🤖 Generated with Claude Code

@github-actions

Copy link
Copy Markdown
Contributor

Tagging Options

Should a new tag be published when this PR is merged?

  • 👍 for Patch 0.160.1 update
  • 🎉 for Minor 0.161.0 update
  • 🚀 for Major 1.0.0 update

@coderabbitai

coderabbitai Bot commented Jul 30, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

📝 Walkthrough

Walkthrough

The PR changes the birthday matcher icon metadata and replaces the user segment matcher’s discriminated-union props with a unified exported interface whose optional months field applies to all segment values.

Changes

Birthday matcher icon

Layer / File(s) Summary
Update birthday matcher icon
vtex/matchers/birthday.ts
Changes the matcher icon metadata from calendar-event to gift.

User segment Props contract

Layer / File(s) Summary
Unify user segment Props
vtex/matchers/userSegment.ts
Replaces segment-specific interfaces and the discriminated union with an exported Props interface; months is optional across all segment values.

Estimated code review effort: 2 (Simple) | ~10 minutes

Possibly related PRs

  • deco-cx/apps#1580: Introduced the birthday matcher in the same file whose icon metadata is updated here.
  • deco-cx/apps#1586: Contains related user segment matcher work involving the exported Props shape.
🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning The description summarizes the change, but it doesn't follow the required template sections or include issue, Loom, or demo links. Rewrite it using the repo template: add What is this Contribution About, Issue Link, Loom Video, and Demonstration Link sections.
✅ Passed checks (4 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Title check ✅ Passed The title matches the birthday icon change, which is a real part of the changeset, though it doesn't mention the reverted userSegment work.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch guitavano/vtex-matcher-forms

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 2 files

Re-trigger cubic

Change `@icon calendar-event` → `@icon gift`. It previously shared the calendar
icon with the generic Date matcher; a gift gives the birthday matcher its own
identity in the admin's matcher picker.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
@guitavano
guitavano force-pushed the guitavano/vtex-matcher-forms branch from 9481570 to f16cba2 Compare July 30, 2026 15:13
@guitavano guitavano changed the title fix(vtex): render userSegment options and give birthday its own icon fix(vtex): give the birthday matcher its own icon Jul 30, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant