Skip to content

feat(runtime): switch page cache to opt-in via PAGE_CACHE_ALLOWED_KEY #1200

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
igoramf merged 1 commit into from
May 22, 2026
Merged

feat(runtime): switch page cache to opt-in via PAGE_CACHE_ALLOWED_KEY #1200

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 3 additions & 4 deletions runtime/middleware.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
// deno-lint-ignore-file no-explicit-any
import { HTTPException } from "@hono/hono/http-exception";
import { DECO_MATCHER_HEADER_QS } from "../blocks/matcher.ts";
import { PAGE_DIRTY_KEY } from "../blocks/utils.tsx";
import { PAGE_CACHE_ALLOWED_KEY } from "../blocks/utils.tsx";
import { Context, context } from "../deco.ts";
import {
type Exception,
Expand Down Expand Up @@ -106,7 +106,6 @@ async (ctx, next) => {

const DEBUG_COOKIE = "deco_debug";
const DEBUG_ENABLED = "enabled";
const PAGE_CACHE_ENABLED = Deno.env.get("DECO_PAGE_CACHE_ENABLED") === "true";
const PAGE_CACHE_CONTROL = Deno.env.get("DECO_PAGE_CACHE_CONTROL") ??
"public, max-age=90, s-maxage=90, stale-while-revalidate=3600, stale-if-error=86400";

Expand Down Expand Up @@ -430,12 +429,12 @@ export const middlewareFor = <TAppManifest extends AppManifest = AppManifest>(
const hasSetCookie = getSetCookies(newHeaders).length > 0;
const contentType = newHeaders.get("Content-Type") ?? "";
const isHtmlResponse = contentType.includes("text/html");
const isPageDirty = ctx.var.bag?.has(PAGE_DIRTY_KEY);
const isPageCacheAllowed = ctx.var.bag?.has(PAGE_CACHE_ALLOWED_KEY);

if (hasSetCookie) {
// Set-cookie present: never cache (same behavior as main)
newHeaders.set("Cache-Control", "no-store, no-cache, must-revalidate");
} else if (isHtmlResponse && PAGE_CACHE_ENABLED && !isPageDirty) {
} else if (isHtmlResponse && isPageCacheAllowed) {
const flags = ctx.var?.flags ?? [];
const allFlagsCacheable = flags.length > 0
? flags.every((flag) => flag.cacheable === true)
Expand Down
Loading