-
Notifications
You must be signed in to change notification settings - Fork 52
Fix url pattern match #911
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Tagging OptionsShould a new tag be published when this PR is merged?
|
b9fe450 to
7305b8c
Compare
7305b8c to
203ac6e
Compare
|
Warning Rate limit exceeded@guitavano has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 12 minutes and 49 seconds before requesting another review. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe change replaces URL construction logic in render.tsx by switching from the Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes The changes involve URL/path parsing logic that requires careful verification of behavioral correctness, particularly around query parameter handling and the URLPattern API compatibility. Single-file scope but logic-dense nature warrants moderate review attention. Poem
Pre-merge checks and finishing touches❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
7b81968 to
c7898ce
Compare
this PR is ralated to #898
this changes adds a wildcard fallback to searchparams once the current version on production of deno has a bug that turn a undefined search as a empty string, this is already fixed on newer versions of deno
Summary by CodeRabbit