-
Notifications
You must be signed in to change notification settings - Fork 196
Temporal SAE integration #575
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This reverts commit c644790.
|
Loading the temporalSAE safetensor using
|
sae_lens/saes/sae.py
Outdated
| normalize_activations: Literal[ | ||
| "none", "expected_average_only_in", "constant_norm_rescale", "layer_norm" | ||
| ] = "none" # none, expected_average_only_in (Anthropic April Update), constant_norm_rescale (Anthropic Feb Update) | ||
| activation_normalization_factor: float = 1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is this needed? I'd rather avoid adding config options to the global SAE config if it's just for temporal SAEs. If constant_norm_rescale isn't used currently we should just delete it from the types IMO. Can you just fold the scaling factor into your temporal SAE weights when you load them so this isn't needed as a separate global SAE config option?
No description provided.