Skip to content

Conversation

@cadmic
Copy link
Contributor

@cadmic cadmic commented Mar 19, 2025

I chose this implementation:

Although the MIPS ISA says that 32-bit ops should produce sign-extended 32-bit values in 64-bit code, it's faster if we let the high bits be garbage instead.

but it seems like strip and probably other 64-bit programs mix 32-bit and 64-bit instructions freely and I'm kinda worried this will cause problems. Now I think it would be better to keep using uint32_t for 32-bit-only programs, and use uint64_t + sign extension everywhere for 64-bit programs.

Probably some of the changes could be kept but I think a clean revert is easier to review.

@AngheloAlf AngheloAlf merged commit 86d98a7 into decompals:main Mar 20, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants