Revert "Use 64-bit register values (#72)" #82
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I chose this implementation:
but it seems like
stripand probably other 64-bit programs mix 32-bit and 64-bit instructions freely and I'm kinda worried this will cause problems. Now I think it would be better to keep usinguint32_tfor 32-bit-only programs, and useuint64_t+ sign extension everywhere for 64-bit programs.Probably some of the changes could be kept but I think a clean revert is easier to review.