Skip to content

findNextFile improvement #82

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

findNextFile improvement #82

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
42eb090
move empty pattern check into while loop
Pheenoh Aug 19, 2024
4bca4a8
early return if pattern is empty
Pheenoh Aug 20, 2024
d9b43a0
comment
Pheenoh Aug 20, 2024
329fb06
Merge branch 'main' into fix2
Pheenoh Aug 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion dll/kernel32.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -701,10 +701,15 @@ namespace kernel32 {
return false;
}

// Early return if pattern is empty
if (handle->pattern.empty()) {
return false;
}

// Look for a matching file with the pattern
while (handle->it != std::filesystem::directory_iterator()) {
std::filesystem::path path = *handle->it;
if (!handle->pattern.empty() && fnmatch(handle->pattern.c_str(), path.filename().c_str(), 0) == 0) {
if (fnmatch(handle->pattern.c_str(), path.filename().c_str(), 0) == 0) {
return true;
}
handle->it++;
Expand Down
Loading