multi: set linkTemplate txntype correctly and refactor #2019
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit fixes a bug where the int value of treasury tx types was used to construct page links instead of its string value. As a result, page navigation on the treasury page did not function correctly because the string value is expected to return correct table values. Others: - Replace duplicated code used in parsing URL params in *explorerUI.TreasuryPage with improved parseTreasuryParams helper function. - Remove unused code from when *explorerUI.AddressPage was used to display treasury data. - Remove resolved TODO and refactor how treasury mempool data is passed to the HTML template. Signed-off-by: Philemon Ukane <[email protected]>
Signed-off-by: Philemon Ukane <[email protected]>
parsePaginationParams is used for both address and treasury page. Both pages have different values as defaults. This commit ensures the correct default is used for each caller. Signed-off-by: Philemon Ukane <[email protected]>
Signed-off-by: Philemon Ukane <[email protected]>
|
#2018 (comment) is fixed in 2b6c76b |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit fixes a bug where the int value of treasury tx types was used to construct page links instead of its string value. As a result, page navigation on the treasury page did not function correctly because the string value is expected to return correct table values.
Others:
*explorerUI.TreasuryPagewith improvedparseTreasuryParamshelper function.Closes #2018