-
Notifications
You must be signed in to change notification settings - Fork 119
bisonw-desktop: follow-up upgrade changes #3281
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Signed-off-by: Philemon Ukane <[email protected]>
With these changes the app will not open. I don't see any logs about why. Also I don't see any shut down logs on master, is it shutting down properly? This breaks something for me. |
You can run the desktop app directly from bisonw-desktop to see what went wrong on your device. |
I've been double clicking, I guess I can try through terminal. |
The stack trace. https://pastebin.com/736Cyszu Also, I am building for arm64 but for some reason its making both that and amd64 .dmg, I think it only made one before. |
The script builds for both arm64 and amd64. |
Signed-off-by: Philemon Ukane <[email protected]>
@JoeGruffins, looking at your stack trace, I suspect the AutoRelease pool thingy...I've replaced it with |
Seeing the same panic with latest changes. |
Which version of Mac are you testing on? |
This PR is a follow-up to #3264.
<null>
args were previously not ignored properly.