Skip to content

bisonw-desktop: follow-up upgrade changes #3281

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

ukane-philemon
Copy link
Contributor

@ukane-philemon ukane-philemon commented May 20, 2025

This PR is a follow-up to #3264.

  1. Notifications work as expected (tested)
  2. Fix bug where <null> args were previously not ignored properly.
  3. Fix typo in comment.
  4. Create the StatusBar when the app finishes launching.
  5. Create the first WebView before the app finishes launching.
  6. Remove redundant/unused objective-c codes.

@ukane-philemon ukane-philemon changed the title bisonw-desktop: follow up upgrade changes bisonw-desktop: follow-up upgrade changes May 20, 2025
@JoeGruffins
Copy link
Member

With these changes the app will not open. I don't see any logs about why. Also I don't see any shut down logs on master, is it shutting down properly?

This breaks something for me.

@ukane-philemon
Copy link
Contributor Author

With these changes the app will not open. I don't see any logs about why. Also I don't see any shut down logs on master, is it shutting down properly?

This breaks something for me.

You can run the desktop app directly from bisonw-desktop to see what went wrong on your device.

@JoeGruffins
Copy link
Member

I've been double clicking, I guess I can try through terminal.

@JoeGruffins
Copy link
Member

The stack trace. https://pastebin.com/736Cyszu

Also, I am building for arm64 but for some reason its making both that and amd64 .dmg, I think it only made one before.

@ukane-philemon
Copy link
Contributor Author

Also, I am building for arm64 but for some reason its making both that and amd64 .dmg, I think it only made one before.

The script builds for both arm64 and amd64.

@ukane-philemon
Copy link
Contributor Author

@JoeGruffins, looking at your stack trace, I suspect the AutoRelease pool thingy...I've replaced it with objc.Retain, which retains the object and sets a finalizer for the Go GC to release.

@JoeGruffins
Copy link
Member

Seeing the same panic with latest changes.

@ukane-philemon
Copy link
Contributor Author

Which version of Mac are you testing on?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants