btc/dcr: Private Atomic Swap wallets #3290
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martonp
force-pushed
the
privateSwapWallets
branch
2 times, most recently
from
67f8b01 to
618b2e7
Compare
martonp
force-pushed
the
privateSwapWallets
branch
from
618b2e7 to
ab492cc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a draft that introduces an interface for wallets that support private atomic swaps and implements it for btc and dcr. For the btc wallet, a still unmerged branch of the
btceclibrary is used that adds adaptor signature support to musig2.The interface will definitely still change, but since @dev-warrior777 is implementing the Monero wallet, it would be good to see if this interface generally works for Monero swaps as well. The communication required between the two parties can be seen in
client/asset/btc/simnet_test.goandclient/asset/dcr/simnet_test.go.I will follow up with implementing the required communication between the client and server and the
corechanges as well.