multi: Return error when sending existing tx.#2093
Draft
JoeGruffins wants to merge 1 commit intodecred:masterfrom
Draft
multi: Return error when sending existing tx.#2093JoeGruffins wants to merge 1 commit intodecred:masterfrom
JoeGruffins wants to merge 1 commit intodecred:masterfrom
Conversation
In chainntfns return an error after logging when a processed transaction already exists. Change all call sites except the wallet publish transaction to ignore these errors to ensure previous behavior of ignoring.
Member
Author
proofThere could be something else that returns errors.Exists, however |
matheusd
reviewed
Feb 3, 2022
Member
matheusd
left a comment
There was a problem hiding this comment.
Seems like a reasonable approach to me
Member
Author
|
I forgot all about this. Will try to update... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #2080