Remove unneeded accountName param from nextAddress#2537
Open
jholdstock wants to merge 1 commit intodecred:masterfrom
Open
Remove unneeded accountName param from nextAddress#2537jholdstock wants to merge 1 commit intodecred:masterfrom
jholdstock wants to merge 1 commit intodecred:masterfrom
Conversation
jrick
reviewed
Sep 12, 2025
jholdstock
force-pushed
the
rmaccnm
branch
2 times, most recently
from
7e65e0e to
03c590c
Compare
jholdstock
force-pushed
the
rmaccnm
branch
2 times, most recently
from
ae8933c to
b562abf
Compare
Member
|
Unsure about this after a quick glance. AccountName() will open a db view, but we might already be in a db update. |
Member
Author
|
I've opened #2561 as an alternative to this PR. Personally I prefer that solution and think this one should be closed, but open to discussion if you have different ideas. |
Member
Author
|
Now making use of the DB txn if it exists. |
To ensure nextAddress is returning valid and helpful information, retrieve the real account name from the database rather than just blindly returning whatever account name was passed as a param (this was often a fake/placeholder value anyway).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To ensure nextAddress is returning valid and helpful information, retrieve the real account name from the database rather than just blindly returning whatever account name was passed as a param (this was often a fake/placeholder value anyway).