[cms] Add proposal token validation for line items#1344
Open
alexlyp wants to merge 1 commit intodecred:masterfrom
Open
[cms] Add proposal token validation for line items#1344alexlyp wants to merge 1 commit intodecred:masterfrom
alexlyp wants to merge 1 commit intodecred:masterfrom
Conversation
|
Will anything bad happen if a non-existing (illegal) but SHA256-looking token is submitted? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There have been some recent instances of users entering bad info into proposal token which has caused problems for pi-gui.
Those issues will be addressed, but this will ensure only proper SHA256 proposal tokens may be entered.