Spv implementation by OrfeasLitos · Pull Request #17 · decrypto-org/TrustIsRisk.js

OrfeasLitos · 2017-09-26T20:24:21Z

No description provided.

A provisional tag is currently used, the correct tag creation procedure will be implemented later.

Done to check if Travis CI sees the commented out lines

OrfeasLitos · 2017-09-26T20:35:09Z

src/trust_is_risk.js


 class TrustIsRisk {
-  node : bcoin$FullNode
+  node : (bcoin$FullNode | bcoin$SPVNode)


node : bcoin$Node

dionyziz · 2017-09-26T20:31:31Z

src/trust_is_risk.js


 class TrustIsRisk {
-  node : bcoin$FullNode
+  node : (bcoin$FullNode | bcoin$SPVNode)


Check if you can type this with the superclass

dionyziz · 2017-09-26T20:32:58Z

src/trust_is_risk.js

+                                                         // secp256k1 curve: y^2 = x^3 + 7
+      0x05, 0x5d, 0x5f, 0x28, 0x5e, 0xd7, 0x9d, 0x0c,
+      0x6f, 0x61, 0xc3, 0x0e, 0xfc, 0x9d, 0x21, 0x91,
+      0x65, 0x82, 0x80, 0x59, 0xa6, 0x01, 0x25, 0x0c,    // 32 bytes with the y coordinate


Keep lines short, move comments above the lines they're describing

dionyziz · 2017-09-26T20:35:17Z

src/trust_is_risk.js

+      0x54, 0x72, 0x75, 0x73, 0x74, 0x20, 0x69, 0x73,
+      0x20, 0x52, 0x69, 0x73, 0x6b, 0x00, 0x00, 0x00,    // only x is given in short version
+      0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
+      0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x01];


DRY, compress using above constants

Removed compressed version entirely

dionyziz · 2017-09-26T20:35:46Z

src/trust_is_risk.js

+    this.fakePubKeyArray = [0x04,            // constant 0x04 prefix
+      0x54, 0x72, 0x75, 0x73, 0x74, 0x20, 0x69, 0x73,
+      0x20, 0x52, 0x69, 0x73, 0x6b, 0x00, 0x00, 0x00,    // 32 bytes with the x coordinate
+      0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,    // containing ASCII "Trust is Risk"


Deduce this from the string 'Trust is Risk' instead of typing it out fully; at least the x part

Removed compressed versions completely

OrfeasLitos · 2017-09-26T20:38:23Z

src/trust_is_risk.js

+    this.tag = Buffer.from(this.fakeKeyRing.getAddress("base58"));
+
+
+    this.compressedFakePubKeyArray = [0x02,                        // 0x02 prefix for even y values


Remove compressed vars

OrfeasLitos · 2017-09-26T20:42:46Z

src/trust_is_risk.js

+  compressedTag : Buffer
+
+  constructor(node : (bcoin$FullNode | bcoin$SPVNode)) {
+    this.fakePubKeyArray = [0x04,            // constant 0x04 prefix


Indent comment correctly

OrfeasLitos · 2017-09-26T20:48:06Z

src/trust_is_risk.js

+  compressedTag : Buffer
+
+  constructor(node : (bcoin$FullNode | bcoin$SPVNode)) {
+    this.fakePubKeyArray = [0x04,            // constant 0x04 prefix


Put the constants out of the class. Use corresponding --harmony flags in the package.json file

@dionyziz There's a million flags, I went one time through them all but they seem to do something else entirely. I read a bit about ESnext and I understood that's a completely separate transpiler (?) that we're currently not using. Can you give me a pointer?

Managed to do it without new flags. Check if the result is OK.

OrfeasLitos · 2017-09-26T20:49:13Z

test/helpers.js


-  getOneOfTwoMultisigOutput: (originPubKey, destPubKey, value) => {
+  getOneOfThreeMultisigOutput: (originPubKey, destPubKey, value) => {
+    tag = (new TrustIsRisk.TrustIsRisk(new bcoin.fullnode({}))).fakePubKey;


use the const that is outside the TrustIsRisk class

OrfeasLitos · 2017-09-26T20:49:47Z

test/helpers.js


-  getOneOfTwoMultisigOutput: (originPubKey, destPubKey, value) => {
+  getOneOfThreeMultisigOutput: (originPubKey, destPubKey, value) => {
+    tag = (new TrustIsRisk.TrustIsRisk(new bcoin.fullnode({}))).fakePubKey;


tag -> fakePubKey

OrfeasLitos · 2017-09-26T20:49:52Z

test/helpers.js

+    tag = (new TrustIsRisk.TrustIsRisk(new bcoin.fullnode({}))).fakePubKey;
    return new bcoin.primitives.Output({
-      script: bcoin.script.fromMultisig(1, 2, [originPubKey, destPubKey]),
+      script: bcoin.script.fromMultisig(1, 3, [originPubKey, destPubKey, tag]),


tag -> fakePubKey

OrfeasLitos · 2017-09-26T20:51:36Z

test/tag-generator.py

@@ -0,0 +1,27 @@
+# Thanks to http://code.activestate.com/recipes/577821-integer-square-root-function/ for isqrt()


move to new directory etc

OrfeasLitos · 2017-09-26T20:53:51Z

test/trust_is_risk.js

+    });
+
+    it("is a valid bitcoin address", () => {
+      assert(bcoin.primitives.Address.fromBase58(tir.tag.toString("ascii")));


bcoin.primitives.Address.fromBase58(tir.tag.toString("ascii")).should.be.ok

OrfeasLitos · 2017-09-26T20:55:26Z

test/trust_is_risk.js

 var sinon = require("sinon");
 var should = require("should");
 var fixtures = require("./fixtures");
+var assert = require("assert");


OrfeasLitos added 30 commits September 12, 2017 18:48

Rename "OneOfTwo" to "OneOfThree"

0927949

Add provisional tag

977df8d

Check trustisrisk tag in trust increasing MTX

f815dc0

Add provisional tag

e36468c

Add tag to trust increasing MTX

3a7eea6

Turn tag from String to Buffer

6efd6fe

Comment out "trustisrisk" tag creation commands

f568294

A provisional tag is currently used, the correct tag creation procedure will be implemented later.

Random change

89b25a0

Done to check if Travis CI sees the commented out lines

Comment out "trustisrisk" tag in test

81e7df4

Replace "equal" with "deepEqual"

f0b1880

Add tag to getTrustDecreasingMTX()

826cd8e

Add provisional "trustisrisk" tag

8c369e5

Add tag to getOneOfThreeMultisigOutput()

e6ec7f0

Add publicKeyArray which contains "Trust is Risk"

5d35bc8

Add public key to addres conversion

f498dd8

Replace buffer.Buffer with Buffer

ac64cfc

Require crypto and base58 from bcoin

b2f2b31

Set i in {crypto,base58} as bcoin.$i

247dc43

Use hash160/256 instead of ripemd/sha

274ec2a

Rename publicKey to pubKey

ca938c3

Convert step2 string to buffer

f695312

Replace hash256 with two sha256

bfba382

Remove "bcoin." before "crypto"

e07ad9d

Use "bcoin.crypto.hash256()"

439581e

Add "hash256()" type

d955c4f

Add missing comma (,)

13bee49

Add "base58()" type

3b0a699

Make all steps' types buffers

0f75dd2

Replace "Address" with "bcoin$Address"

3fc5f18

Replace "bcoin$Address" with "Buffer"

58aa495

OrfeasLitos commented Sep 26, 2017

View reviewed changes

dionyziz requested changes Sep 26, 2017

View reviewed changes

OrfeasLitos commented Sep 26, 2017

View reviewed changes

OrfeasLitos added 15 commits September 27, 2017 12:17

Define bcoin, inherit full and spv

f0eb7ca

Align with other comments

013c706

Remove compressed version of tag

3869c2b

Put comments in their own lines

6fa62ab

Replace tag with fakePubKey

d271530

Move to etc

fc20631

Refer to etc/tag-generator.py

14fdf56

Stop using assert()

ed5f986

Add tag stuff out of class

9f01cf9

Use fakePubKey outside class

1e436e5

Export fakePubKey and tag

a079369

Use ".Tir" to refer to TrustIsRisk

f41b005

Use exported fakePubKey and tag

5cfacdc

Remove tag definitions from TrustIsRisk class

b2bc8b6

Rename "Tir" to "TIR"

67b294c

OrfeasLitos closed this Oct 1, 2017

OrfeasLitos reopened this Oct 1, 2017

OrfeasLitos added 2 commits October 1, 2017 18:56

Remove redundant "NodeWatcher" definition

43a5e69

Fix comment appearance and typo

247c8b1

		this.tag = Buffer.from(this.fakeKeyRing.getAddress("base58"));


		this.compressedFakePubKeyArray = [0x02, // 0x02 prefix for even y values

		@@ -0,0 +1,27 @@
		# Thanks to http://code.activestate.com/recipes/577821-integer-square-root-function/ for isqrt()

Conversation

OrfeasLitos commented Sep 26, 2017

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

OrfeasLitos Sep 27, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

OrfeasLitos Sep 26, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

OrfeasLitos Sep 26, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

OrfeasLitos Sep 27, 2017 •

edited

Loading

OrfeasLitos Sep 26, 2017 •

edited

Loading

OrfeasLitos Sep 26, 2017 •

edited

Loading