Fix package in asm generator#598
Merged
Merged
Conversation
|
🔒 Could not start CI tests due to missing safe PR label. Please contact a DEDIS maintainer. |
|
🔒 Could not start CI tests due to missing safe PR label. Please contact a DEDIS maintainer. |
jbsv
approved these changes
Jan 6, 2026
jbsv
left a comment
jbsv
left a comment
Contributor
There was a problem hiding this comment.
please add in the readme why we use a copy of this package
thehoul
commented
Jan 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Based on this comment from Yolan: #579 (comment)
Also, as it regards bigmod, we can address this comment #579 (comment) by adding info in the README. Note that we can't move this package to internal because we do return a compatible.Int