Skip to content

Improved SchemaValidator by adding an option to disable schemas from schemaLocation #1928

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
copierrj merged 1 commit into from
Jan 28, 2026
+71 −4
Merged

Improved SchemaValidator by adding an option to disable schemas from schemaLocation #1928

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
75 changes: 71 additions & 4 deletions ...re/deegree-core-commons/src/main/java/org/deegree/commons/xml/schema/SchemaValidator.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,6 +104,12 @@ public class SchemaValidator {
*/
private static final String HONOUR_ALL_SCHEMA_LOCATIONS_ID = "http://apache.org/xml/features/honour-all-schemaLocations";

/**
* use only schema components from the grammar pool provided
* (http://apache.org/xml/features/internal/validation/schema/use-grammar-pool-only).
*/
public static final String USE_GRAMMAR_POOL_ONLY = "http://apache.org/xml/features/internal/validation/schema/use-grammar-pool-only";

/**
* Validates the specified XML instance document according to the contained schema
* references ( <code>xsi:schemaLocation</code> attribute) and/or to the explicitly
Expand All @@ -115,7 +121,25 @@ public class SchemaValidator {
* of 0 means valid document
*/
public static List<SchemaValidationEvent> validate(InputStream source, String... schemaUris) {
return validate(new XMLInputSource(null, null, null, source, null), schemaUris);
return validate(source, false, schemaUris);
}

/**
* Validates the specified XML instance document according to the contained schema
* references ( <code>xsi:schemaLocation</code> attribute) and/or to the explicitly
* specified schema references.
* @param source provides the XML document to be validated, must not be null
* @param useGrammarPoolOnly <code>true</code> if only the passed schemas should be
* used for validation, <code>false</code> if the schemaLocation from the XML document
* should be used additionally
* @param schemaUris URIs of schema documents to be considered, can be null (only the
* <code>xsi:schemaLocation</code> attribute is considered then)
* @return list of validation events (errors/warnings) that occured, never null, size
* of 0 means valid document
*/
public static List<SchemaValidationEvent> validate(InputStream source, boolean useGrammarPoolOnly,
String... schemaUris) {
return validate(new XMLInputSource(null, null, null, source, null), useGrammarPoolOnly, schemaUris);
}

/**
Expand All @@ -132,8 +156,28 @@ public static List<SchemaValidationEvent> validate(InputStream source, String...
*/
public static List<SchemaValidationEvent> validate(String url, String... schemaUris)
throws MalformedURLException, IOException {
return validate(url, false, schemaUris);
}

/**
* Validates the specified XML instance document according to the contained schema
* references ( <code>xsi:schemaLocation</code> attribute) and/or to the explicitly
* specified schema references.
* @param url provides the XML document to be validated, must not be null
* @param useGrammarPoolOnly <code>true</code> if only the passed schemas should be
* used for validation, <code>false</code> if the schemaLocation from the XML document
* should be used additionally
* @param schemaUris URIs of schema documents to be considered, can be null (only the
* <code>xsi:schemaLocation</code> attribute is considered then)
* @return list of validation events (errors/warnings) that occured, never null, size
* of 0 means valid document
* @throws IOException
* @throws MalformedURLException
*/
public static List<SchemaValidationEvent> validate(String url, boolean useGrammarPoolOnly, String... schemaUris)
throws MalformedURLException, IOException {
InputStream is = ProxySettings.openURLConnection(new URL(url), null, null).getInputStream();
return validate(new XMLInputSource(null, null, null, is, null), schemaUris);
return validate(new XMLInputSource(null, null, null, is, null), useGrammarPoolOnly, schemaUris);
}

/**
Expand All @@ -148,6 +192,26 @@ public static List<SchemaValidationEvent> validate(String url, String... schemaU
* <code>null</code>, size of 0 means valid document
*/
public static List<SchemaValidationEvent> validate(XMLInputSource source, String... schemaUris) {
return validate(source, false, schemaUris);
}

/**
* Validates the specified XML instance document according to the contained schema
* references ( <code>xsi:schemaLocation</code> attribute) and/or to explicitly
* specified schema references.
* @param source provides the document to be validated, must not be <code>null</code>
* @param source provides the XML document to be validated, must not be null
* @param useGrammarPoolOnly <code>true</code> if only the passed schemas should be
* used for validation, <code>false</code> if the schemaLocation from the XML document
* should be used additionally
* @param schemaUris URIs of schema documents to be considered, can be
* <code>null</code> (only the <code>xsi:schemaLocation</code> attribute is considered
* then)
* @return list of validation events (errors/warnings) that occurred, never
* <code>null</code>, size of 0 means valid document
*/
public static List<SchemaValidationEvent> validate(XMLInputSource source, boolean useGrammarPoolOnly,
String... schemaUris) {
final List<SchemaValidationEvent> errors = new LinkedList<SchemaValidationEvent>();

try {
Expand All @@ -158,7 +222,8 @@ public static List<SchemaValidationEvent> validate(XMLInputSource source, String
}
}
GrammarPool grammarPool = (schemaUris == null ? null : GrammarPoolManager.getGrammarPool(schemaUris));
XMLParserConfiguration parserConfig = createValidatingParser(new RedirectingEntityResolver(), grammarPool);
XMLParserConfiguration parserConfig = createValidatingParser(new RedirectingEntityResolver(), grammarPool,
useGrammarPoolOnly);
parserConfig.setErrorHandler(new XMLErrorHandler() {
@SuppressWarnings("synthetic-access")
@Override
Expand Down Expand Up @@ -277,7 +342,7 @@ private String toString(XMLParseException e) {
}

private static XMLParserConfiguration createValidatingParser(XMLEntityResolver entityResolver,
GrammarPool grammarPool) throws XNIException {
GrammarPool grammarPool, boolean useGrammarPoolOnly) throws XNIException {

XMLParserConfiguration parserConfiguration = null;
if (grammarPool == null) {
Expand All @@ -296,6 +361,8 @@ private static XMLParserConfiguration createValidatingParser(XMLEntityResolver e
if (entityResolver != null) {
parserConfiguration.setEntityResolver(entityResolver);
}
if (useGrammarPoolOnly)
parserConfiguration.setFeature(USE_GRAMMAR_POOL_ONLY, true);
return parserConfiguration;
}

Expand Down