Fixed WMS response if remote layer cannot be retrieved#1931
Merged
copierrj merged 3 commits intodeegree:mainfrom Jan 28, 2026
Merged
Fixed WMS response if remote layer cannot be retrieved#1931copierrj merged 3 commits intodeegree:mainfrom
copierrj merged 3 commits intodeegree:mainfrom
Conversation
stephanr
approved these changes
Jan 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1926
Currently, when a remote layer is requested and this layer does not respond with an image (e.g. exception, timeout), the WMS response of deegree is an empty image. Thus, the user does not know if the layer does not work or if there is no data in the requested BBOX.
This PR fixes the behavior by recognizing the erroneous response of the remote layer and passing an error message to the user of the deegree WMS.
Examples for new behavior:
EXCEPTIONS=XMLis passed: Same behavior as before.EXCEPTIONS=INIMAGEis passed: Image is returned with this text in upper left corner:Error: Error retrieving remote map.