Fix SpeechStartedResponse.Channel mapped property#407
Conversation
|
Hi @richardszalay, thank you for the fix. I've confirmed against our AsyncAPI spec ( One thing I have noticed while reviewing is the same bug exists in For reference, |
|
@GregHolmes Done! While I have you looking at my PR, would you consider merging #408 for the next release too? |
|
Thank you @richardszalay I'll look at #408 now. |
|
Hi @GregHolmes, do you have any indication when these PRs can be merged/released? We're running into some issues around multi-channel events and this would help us resolve it. |
@richardszalay I'm sorry for the delay, there were a few hoops for me to jump through to get this release out. I've just pushed the release and can see it appearing as |
|
Thanks @GregHolmes! |
Proposed changes
The
SpeechStartedResponseclass is intended to represent the ListenV1SpeechStarted type from the listen WebSocket endpoint.SpeechStartedResponse.Channeldefines a JSON mapping of[JsonPropertyName("channel_index")], but this is incorrect as the documentation defines this property aschanneland data returned from the actual API aligns with the documentation.This PR simply corrects the mapped JSON so that the
Channelproperty is populated correctly.Types of changes
What types of changes does your code introduce to the community .NET SDK?
Put an
xin the boxes that applyChecklist
Put an
xin the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.