Skip to content

chore: add nova-3 models, add deprecation warnings to legacy models #108

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Apr 16, 2025

Conversation

thisislvca
Copy link
Contributor

Proposed changes

Just some basic chores. I'm using this SDK in production, and I'm having to create a custom model id in order to use nova-3. Now that it's released, I think it'd be nice to add it to the SDK too.

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update or tests (if none of the other choices apply)

Checklist

  • I have read the CONTRIBUTING.md doc
  • I have added tests and/or examples that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

As a side note, in CONTRIBUTING.md you guys ask that PRs are created on the dev branch, but it doesn't exist...

@ashutoshxhq
Copy link

@thisislvca waiting on this.

@thisislvca
Copy link
Contributor Author

hey! I'm not on the deepgram team, I think @jcdyer is the core maintainer of this crate. Hopefully they can merge this soon :)

@bd-g
Copy link
Contributor

bd-g commented Apr 11, 2025

Thanks for the PR! Good catch on the dev branch - this SDK is still in the process of being "officialized", so some of the edges aren't polished yet.

I like the idea of matching the model deprecation attributes to the official Deepgram documentation.

@thisislvca
Copy link
Contributor Author

Hey @bd-g updated everything, it should now work :)

Changed the "deprecated since" to 0.6.8 as that's the next release number, but lmk if you plan to public this as 0.7.0 or smth else, will update it.

@bd-g bd-g merged commit cc2f4c3 into deepgram:main Apr 16, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants