feat: DH-10139: Introduce structured errors for input table updates. #7113

cpwright · 2025-08-20T20:59:11Z

No description provided.

mofojed

If we could get a structured object back with the errors that would be better long-term; not only could we highlight the cells that have the errors, it would be essential if we ever want to internationalize our application.
Would eliminate much of the string building/formatting going on in this PR.

github-actions · 2025-09-17T10:34:00Z

No docs changes detected for `67fbe8f`

gradle/libs.versions.toml

devinrsmith · 2025-09-17T15:16:17Z

engine/table/src/main/java/io/deephaven/engine/util/input/InputTableValidationException.java

+     * </p>
+     * .
+     */
+    public interface StructuredError {


Any reason this needs to be an interface? Seems like we can just have a concrete class (like StructuredErrorImpl).

devinrsmith · 2025-09-17T15:25:45Z

server/src/main/java/io/deephaven/server/table/inputtables/InputTableServiceGrpcImpl.java

+                                GrpcUtil.safelyError(responseObserver, StatusProto.toStatusException(status));
+                                return;


How does this compare to throw StatusProto.toStatusRuntimeException(status);?

server/src/main/java/io/deephaven/server/table/inputtables/RangeValidatingInputTable.java

…able-experiments

niloc132 · 2025-10-23T14:35:00Z

server/src/main/java/io/deephaven/server/table/inputtables/RangeValidatingInputTable.java

+ * </p>
+ */
+@TestUseOnly
+public class RangeValidatingInputTable implements InputTableUpdater {


call make with an input table and an integer column and a min and a max

that's the easiest way to make one, start testing it out

…able-experiments

engine/table/src/main/java/io/deephaven/engine/util/input/InputTableValidationException.java

proto/proto-backplane-grpc/src/main/proto/deephaven_core/proto/inputtable.proto

gradle/libs.versions.toml

…able-experiments

…tTableValidationException.java Co-authored-by: Colin Alworth <[email protected]>

…ight/deephaven-core into nightly/cpw/input-table-experiments

…able-experiments

jmao-denver · 2025-12-31T16:04:49Z

py/client/examples/demo_input_table_update.py

+#
+# Copyright (c) 2016-2025 Deephaven Data Labs and Patent Pending
+#
+
+"""Demo how to chain table operations."""
+
+from pydeephaven import Session, Table, DHError
+from pydeephaven.table import InputTable
+import pyarrow as pa
+from datetime import datetime
+import time
+from grpc_status import rpc_status
+import grpc
+from google.protobuf.any_pb2 import Any
+from deephaven_core.proto.inputtable_pb2 import InputTableValidationErrorList
+
+err = None
+stat = None
+err_list = None
+
+def main():


doc string is wrong

do we want to add a test case in addition to this example?

is formal documentation needed ( a link to the demo could suffice)

I updated the docstring to be more helpful.

deephaven-core/py/client/tests/test_session.py

Line 148 in 68fd5ad

keyed_input_t = self.session.input_table(schema=schema, key_cols="f1")

has a test of an input table addition already

There are no production grade validations available from Core. The input table operations remain compatible, without any need to change the Python documentation.

jmao-denver · 2025-12-31T16:06:01Z

py/client/examples/demo_input_table_update.py

+            except DHError as dhe:
+                err = dhe
+                parent = dhe.__cause__
+                while parent is not None:
+                    if isinstance(parent, grpc.Call):
+                        stat = rpc_status.from_call(parent)
+                        parent = None
+
+                        for detail in stat.details:
+                            if detail.type_url == "type.googleapis.com/" + InputTableValidationErrorList.DESCRIPTOR.full_name:
+                                el = InputTableValidationErrorList()
+                                if detail.Unpack(el):
+                                    err_list = el
+                                else:
+                                    print("Could not unpack: " + detail)
+                    else:
+                        parent = parent.__cause__
+
+                raise


Is a public helper function in the API to wrap all these parsing justified?

No, this is just to prove that we could extract them if we wanted. There is a formatted message passed along in the error string. But if we are to use the googlerpc status library in more places, we do want to make sure that the languages we care about work.

jmao-denver

The Python changes LGTM

cpwright requested review from mofojed and niloc132 August 20, 2025 20:59

cpwright force-pushed the nightly/cpw/input-table-experiments branch 2 times, most recently from c85adfa to 7c93440 Compare August 28, 2025 21:40

mofojed reviewed Sep 12, 2025

View reviewed changes

cpwright added 3 commits September 17, 2025 06:33

feat: DH-15846: Core+ InputTables do not enforce enums.

a03bed3

Example of extracting errors from Java.

b516bae

Python detail extraction, needs grpcio-status.

a5dba61

cpwright force-pushed the nightly/cpw/input-table-experiments branch from 7c93440 to a5dba61 Compare September 17, 2025 10:33

devinrsmith reviewed Sep 17, 2025

View reviewed changes

cpwright added 3 commits October 1, 2025 08:40

Merge remote-tracking branch 'upstream/main' into nightly/cpw/input-t…

b6f6dad

…able-experiments

Comments and toml update.

9f47036

typo

5c93106

niloc132 reviewed Dec 18, 2025

View reviewed changes

cpwright added 4 commits December 19, 2025 12:26

Merge remote-tracking branch 'upstream/main' into nightly/cpw/input-t…

67fbc62

…able-experiments

remove test that shouldn't yet exist.

1ac26cb

Protobuf update.

642ff67

ruff

f12eb20

cpwright added NoDocumentationNeeded NoReleaseNotesNeeded No release notes are needed. labels Dec 22, 2025

cpwright self-assigned this Dec 22, 2025

test filters shouldn't have been updated.

f073df2

cpwright changed the title ~~WIP: Introduce structured errors for input table updates.~~ feat: DH-10139: Introduce structured errors for input table updates. Dec 22, 2025

cpwright marked this pull request as ready for review December 22, 2025 14:30

cpwright requested review from chipkent, jmao-denver and rcaudy as code owners December 22, 2025 14:30

cpwright added 2 commits December 22, 2025 09:50

Improve documentation of InputTableValidationErrorList.

86dae9e

Use SRE instead of StatusException.

7f309c7

cpwright added 3 commits December 22, 2025 10:10

regenerate python protos

f1e6285

go protobuf update.

6d51d95

spotless

d70b0bd

cpwright enabled auto-merge (squash) December 22, 2025 16:30

niloc132 reviewed Dec 30, 2025

View reviewed changes

cpwright and others added 9 commits December 30, 2025 11:51

Merge remote-tracking branch 'upstream/main' into nightly/cpw/input-t…

a520b05

…able-experiments

version bump

d4800d7

Update engine/table/src/main/java/io/deephaven/engine/util/input/Inpu…

4e9ca7e

…tTableValidationException.java Co-authored-by: Colin Alworth <[email protected]>

Update engine/table/src/main/java/io/deephaven/engine/util/input/Inpu…

6627718

…tTableValidationException.java Co-authored-by: Colin Alworth <[email protected]>

Merge branch 'nightly/cpw/input-table-experiments' of github.com:cpwr…

f8b033b

…ight/deephaven-core into nightly/cpw/input-table-experiments

add reference to error message in rpc call docs

04ac8e5

regen go/py protobufs

311141b

Merge remote-tracking branch 'upstream/main' into nightly/cpw/input-t…

223752f

…able-experiments

update after upstream merge

8c2e70a

niloc132 previously approved these changes Dec 30, 2025

View reviewed changes

jmao-denver reviewed Dec 31, 2025

View reviewed changes

Add documentation to example.

67fbe8f

cpwright dismissed niloc132’s stale review via 67fbe8f December 31, 2025 17:32

jmao-denver approved these changes Dec 31, 2025

View reviewed changes

niloc132 approved these changes Jan 1, 2026

View reviewed changes

rcaudy approved these changes Jan 1, 2026

View reviewed changes

cpwright merged commit 1abb24e into deephaven:main Jan 1, 2026
24 checks passed

github-actions bot locked and limited conversation to collaborators Jan 1, 2026

		GrpcUtil.safelyError(responseObserver, StatusProto.toStatusException(status));
		return;

feat: DH-10139: Introduce structured errors for input table updates. #7113

feat: DH-10139: Introduce structured errors for input table updates. #7113

Conversation

cpwright commented Aug 20, 2025

Uh oh!

mofojed left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Sep 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

No docs changes detected for 67fbe8f

Uh oh!

Uh oh!

devinrsmith Sep 17, 2025

Choose a reason for hiding this comment

Uh oh!

devinrsmith Sep 17, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

niloc132 Oct 23, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

jmao-denver Dec 31, 2025

Choose a reason for hiding this comment

Uh oh!

cpwright Dec 31, 2025

Choose a reason for hiding this comment

Uh oh!

jmao-denver Dec 31, 2025

Choose a reason for hiding this comment

Uh oh!

cpwright Dec 31, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jmao-denver left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

github-actions bot commented Sep 17, 2025 •

edited

Loading

No docs changes detected for `67fbe8f`

cpwright Dec 31, 2025 •

edited

Loading