chore: Increase default concurrency for plugin dev #1270
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The default concurrency value for
lernais to use the number of logical cores. In cases where the number of logical cores is < the number of plugins,npm start:packageswill only build some of the plugins.For example, on my Mac, I have 10 logical cores, and we now have 11 plugins. This resulted in
uiplugin not being built.This PR increases the default to 20 which gives us some cushion to grow in the number of plugins.
Testing
I have tested this by running
npm starton my machine which has 10 logical cores. All 11 plugins ran in watch mode. Without the--concurrency 20flag, only 10 of them run.