Skip to content

Conversation

@mofojed
Copy link
Member

@mofojed mofojed commented Jan 14, 2026

  • We were tryin to dehydrate the CellData object instead of the value itself
  • Just dehydrate the value itself
  • Fix the tests
  • This seems to have been broken for a long time, and only now it's being caught when attempting to persist deephaven.ui data

- We were tryin to dehydrate the CellData object instead of the value itself
- Just dehydrate the value itself
- Fix the tests
- This seems to have been broken for a long time, and only now it's being caught when attempting to persist deephaven.ui data
@mofojed mofojed requested a review from vbabich January 14, 2026 19:48
@mofojed mofojed self-assigned this Jan 14, 2026
@codecov
Copy link

codecov bot commented Jan 14, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 45.96%. Comparing base (ff7b424) to head (11ca029).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2606      +/-   ##
==========================================
+ Coverage   45.71%   45.96%   +0.25%     
==========================================
  Files         771      771              
  Lines       43652    43652              
  Branches    11231    11231              
==========================================
+ Hits        19954    20065     +111     
+ Misses      23653    23570      -83     
+ Partials       45       17      -28     
Flag Coverage Δ
unit 45.96% <100.00%> (+0.25%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@mofojed mofojed merged commit 11df934 into deephaven:main Jan 16, 2026
11 checks passed
@mofojed mofojed deleted the bender_DH-21407-input-table-dates branch January 16, 2026 13:54
@github-actions github-actions bot locked and limited conversation to collaborators Jan 16, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants