Skip to content

Conversation

@mofojed
Copy link
Member

@mofojed mofojed commented Jan 16, 2026

  • We were tryin to dehydrate the CellData object instead of the value itself
  • Just dehydrate the value itself
  • Fix the tests
  • This seems to have been broken for a long time, and only now it's being caught when attempting to persist deephaven.ui data

- We were tryin to dehydrate the CellData object instead of the value
itself
- Just dehydrate the value itself
- Fix the tests
- This seems to have been broken for a long time, and only now it's
being caught when attempting to persist deephaven.ui data
@mofojed mofojed requested a review from vbabich January 16, 2026 14:01
@mofojed mofojed self-assigned this Jan 16, 2026
@codecov
Copy link

codecov bot commented Jan 16, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 48.57%. Comparing base (549e4e9) to head (65bfd28).
⚠️ Report is 2 commits behind head on release/v0.85.

Additional details and impacted files
@@                Coverage Diff                @@
##           release/v0.85    #2609      +/-   ##
=================================================
+ Coverage          48.44%   48.57%   +0.12%     
=================================================
  Files                712      712              
  Lines              39761    39789      +28     
  Branches           10121    10129       +8     
=================================================
+ Hits               19263    19326      +63     
+ Misses             20485    20406      -79     
- Partials              13       57      +44     
Flag Coverage Δ
unit 48.57% <100.00%> (+0.12%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant