fix(ngtcp2): CVE-2024-52811#3
Open
deepin-ci-robot wants to merge 1 commit intomasterfrom
Open
Conversation
Fix heap buffer overflow when writing not validated ACK to qlog. In conn_recv_pkt for an ACK, there was logic to skip conn_recv_ack if an ack has already been processed in the payload. However, this causes us to also skip ngtcp2_pkt_validate_ack. The ack which was skipped still got written to qlog, leading to a heap overflow. Upstream: ngtcp2/ngtcp2@44b662b Generated-By: glm-5.1 Co-Authored-By: Security Agent <security@openclaw.ai>
Author
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
TAG Bot TAG: 1.6.0-1deepin1 |
|
/integrate |
|
AutoIntegrationPr Bot |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CVE-2024-52811 修复
漏洞描述
Fix heap buffer overflow when writing not validated ACK to qlog.
在 ngtcp2_conn::conn_recv_pkt 处理 ACK 帧时,新增的逻辑跳过了 conn_recv_ack,导致同时跳过了 ngtcp2_pkt_validate_ack 验证。未验证的 ACK 仍然被写入 qlog,导致堆缓冲区溢出。
修复内容
相关链接
Commit 信息
🤖 Generated by CVE-Fixer AI Agent