-
Notifications
You must be signed in to change notification settings - Fork 5.9k
replace Albumentations with AlbumentationsX #2794
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
But unfortunately, the licences are not compatible.
Including AlbumentationsX into Insightface would make all of Insightface fall under the AGPL licence unless the user has paid for AlbumentationsX. |
That's not true. Insightface only uses Albumentations' API, so its code can have a different license. |
|
But it would create quite severe restrictions on any project that wants to depend on Insightface because of the transitive dependence on AlbumentationsX. Even if Insightface's licence could remain the same, projects using Insightface would have to abide by the restrictions of AlbumentationsX's licence. |
|
Hi all, thank you for the valuable discussion. I also did find that the albumentations library needs to be updated. Is there a clear answer regarding the license issue at the moment? |
|
This is my understanding of the consequences of upgrading Albumentations to AlbumentationsX.
This does not address the open question (rightly raised by @dotlambda ) of whether Insightface itself does or does not have to be licenced under AGPL. Does importing AlbumentationsX already mean that Insightface is a derivative work? That I do not know. But from my perspective, the licence implications to users of Insighface are problematic enough that I would recommend instead to remove Albumentations from the library and replace it with some other data augmentation library. |
It does not:
https://www.gnu.org/licenses/gpl-faq.html#LinkingWithGPL Note again that the MIT license is in fact compatible. |
|
As mentioned, you can link an MIT project against a(n A)GPL project. In addition to dotlambda's link, https://www.gnu.org/licenses/license-list.html#Expat is where the FSF says the MIT license is compatible. |
|
I think you might be mixing up AGPL and LGPL. The MIT license is NOT compatible with the AGPL license. The AGPL license has stricter requirements in terms of requiring the availability of source code for derivative works, and @martinsbruveris is correct with their analysis in #2794 (comment). Also, from part of https://www.gnu.org/licenses/gpl-faq.html#MereAggregation:
|
|
您好,我已经收到您的邮件,尽快给您回复。
|
|
(I agree that importing counts as linking/combined.) The link @dotlambda provided is about the GPL, not the LGPL. It all but certainly applies to the AGPL too as the provisions it references are not compromised by AGPL's only difference, the "addition" of section 13. Though the GPL is not compatible with the MIT/Expat License, as I mentioned above, the FSF has explicitly stated that the MIT/Expat License is compatible with the GPL, and that is what matters for whether we can import albumentationsx.
|
https://github.com/albumentations-team/AlbumentationsX