WIP: Make MPS default device for macOS M1#2044
Draft
frankfliu wants to merge 1 commit intodeepjavalibrary:masterfrom
Draft
WIP: Make MPS default device for macOS M1#2044frankfliu wants to merge 1 commit intodeepjavalibrary:masterfrom
frankfliu wants to merge 1 commit intodeepjavalibrary:masterfrom
Conversation
frankfliu
changed the title
Codecov ReportBase: 72.08% // Head: 69.61% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #2044 +/- ##
============================================
- Coverage 72.08% 69.61% -2.48%
- Complexity 5126 5964 +838
============================================
Files 473 597 +124
Lines 21970 26510 +4540
Branches 2351 2884 +533
============================================
+ Hits 15838 18456 +2618
- Misses 4925 6664 +1739
- Partials 1207 1390 +183
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
demq
reviewed
Oct 3, 2022
| String[] extraFileKeys, | ||
| String[] extraFileValues) { | ||
| Device device = manager.getDevice(); | ||
| // MPS doesn't support mapLocation |
Contributor
There was a problem hiding this comment.
@frankfliu - Could you please add the changes that disable "mapLocation" for "mps" to the master? This will improve the current "mps" support.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently MPS has many limitations:
.toDevice(): _ZN2at6native3mps13copy_cast_mpsThis PR is just used as a reference, will make MPS default device when it become stable