Repository navigation
The docs say Jira Cloud pages by token without a total, and the Jira fetch takes the Cloud flag like the GitHub one - #1461
Merged
Conversation
…fetch takes the Cloud flag like the GitHub one Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Wayland Yang <wayland@Mac.bbrouter>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #1453.
Docs.
docs/design/sources.mdand ADR 0072 still said Jira requires the searchtotalto detect a premature end. That is now true only for Server and Data Center. Jira Cloud'ssearch/jqlhas no total (Atlassian CHANGE-2046), so there an empty page, or a page withoutnextPageToken, beforeisLastfails the run. Both now say so.Code. #1453 added a
fetch_windowwrapper that only computedis_jira_cloud(base_url)and calledfetch_window_on, so that tests could force the Cloud path against a local mock.github_issues::fetch_windowalready takes its mode as a plainboolfrom the caller, so the Jira one now does the same: one function,is_jira_cloudis public, andsync_jira_issuespasses it. No behaviour change. The production code loses the 20-line wrapper; the test diff is mostly rustfmt rewrapping calls that gained an argument.Checked:
cargo fmt --all,cargo clippy -p utopia-server --all-targets -- -D warnings, andcargo test -p utopia-server jira(16 passed).🤖 Generated with Claude Code