Skip to content

I/O improvements #42

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 32 commits into
base: master
Choose a base branch
from
Draft

I/O improvements #42

wants to merge 32 commits into from

Conversation

wx4stg
Copy link
Contributor

@wx4stg wx4stg commented Jul 1, 2024

Better station identification across multiple files (and hopefully, networks, in a few commits...)

@wx4stg
Copy link
Contributor Author

wx4stg commented Jul 1, 2024

"number_of_configurations" instead of "number_of_files", make station_active uint8

@codecov-commenter
Copy link

codecov-commenter commented Jul 19, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 50.00000% with 80 lines in your changes missing coverage. Please review.

Project coverage is 75.80%. Comparing base (f392af2) to head (27b3c10).

Files Patch % Lines
pyxlma/lmalib/io/read.py 59.70% 54 Missing ⚠️
pyxlma/lmalib/io/write.py 0.00% 26 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master      #42      +/-   ##
==========================================
- Coverage   78.12%   75.80%   -2.32%     
==========================================
  Files          13       14       +1     
  Lines        1865     2013     +148     
==========================================
+ Hits         1457     1526      +69     
- Misses        408      487      +79     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@wx4stg
Copy link
Contributor Author

wx4stg commented Jul 20, 2024

48468df was supposed to go on #41 :/

@wx4stg
Copy link
Contributor Author

wx4stg commented Jul 24, 2024

@wx4stg
Copy link
Contributor Author

wx4stg commented Jul 28, 2024

the way that I'm calculating station_power_ratio is probably wrong, but I couldn't find any docs on how to do it properly...

@wx4stg
Copy link
Contributor Author

wx4stg commented Jul 28, 2024

Station data tables produced by lma_analysis versions (at least) 10.14.9R and 10.14.5R have one extra header than they do data. dec_win(us) doesn't seem to actually be included in the table.

reading these files in to XLMA works okay because read_lma.pro looks for a line starting with 'Sta_dat' (L300) to detect the start of a station data line, but lma_analysis writes "Sta_data". If the data file is edited to use 'Sta_dat' instead, XLMA crashes when reading in the file. This suggests that the 'using the wrong prefix' bug just so happens to fix the 'one extra header' bug, but this situation isn't exactly ideal

@wx4stg
Copy link
Contributor Author

wx4stg commented Jul 28, 2024

Oklahoma and Houston LMA info tables report board revision 52 for all their antennas, but West Texas LMA antennas are revision 3? we're using some really old hardware here.... or something else strange is happening..

interestingly, 3 is the same value as the next column, rec_ch (receiver channels?) which is an interesting tale itself, as XLMA does not recognize this column as a valid header, but it's present in every file I've seen produced by lma_analysis

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants