Skip to content

Traversal tests, bug fix #62

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Conversation

wx4stg
Copy link
Contributor

@wx4stg wx4stg commented Feb 24, 2025

Ran into this bug when running traversal with ecb_tobac_timeseries.py. Newer xarray groupby operations give single element slices instead of integer indices. This forces integer indices

Also brought over tests from glmtools.

@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 50.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 75.16%. Comparing base (97f8aaa) to head (31a3f75).

Files with missing lines Patch % Lines
pyxlma/lmalib/traversal.py 50.00% 2 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master      #62      +/-   ##
==========================================
+ Coverage   73.20%   75.16%   +1.96%     
==========================================
  Files          16       16              
  Lines        2086     2090       +4     
==========================================
+ Hits         1527     1571      +44     
+ Misses        559      519      -40     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@deeplycloudy
Copy link
Owner

Could you see if this has any impact on deeplycloudy/glmtools#104?

@wx4stg
Copy link
Contributor Author

wx4stg commented Mar 7, 2025

The check_parent_child method is not implemented on the pyxlma version of traversal, so this bug isn't present. Is there any interest in adding that method here?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants