Skip to content

Tests: Update DeePKS UT to make sure it covers some checks. - #6480

Merged
mohanchen merged 8 commits into
deepmodeling:developfrom
ErjieWu:fix
Sep 15, 2025
Merged

Tests: Update DeePKS UT to make sure it covers some checks.#6480
mohanchen merged 8 commits into
deepmodeling:developfrom
ErjieWu:fix

Conversation

@ErjieWu

@ErjieWu ErjieWu commented Sep 5, 2025

Copy link
Copy Markdown
Collaborator

Unit Tests and/or Case Tests for my changes

  • Unit test (multi-k) for DeePKS is changed to make sure it covers the check mentioned in issue Result of vdrpre maybe wrong in DeePKS. #6474. Cell is set to smaller one to make sure there are overlaps between l>0 orbitals in different Bravo lattice. This check will inevitably make the reference file larger.
  • Use smaller projected orbital for DeePKS UT to reduce the size of reference files.

What's changed?

  • Add a index check for vdr in DeePKS to make sure the index will not be out of range we want.
  • Add a WARNING_QUIT if model file not exist in DeePKS.

@ErjieWu ErjieWu added Machine Learning & AI Issues related to AI Tests/Examples Issues/PR related to unit tests and integrate tests labels Sep 5, 2025
@ErjieWu
ErjieWu requested a review from mohanchen September 5, 2025 06:09
Comment thread tests/09_DeePKS/100_NO_KP_deepks_UT/gdmx_ref.dat
@ErjieWu

ErjieWu commented Sep 9, 2025

Copy link
Copy Markdown
Collaborator Author

@mohanchen Simplification for UT finished. Ready for merge.

@mohanchen
mohanchen merged commit c931d97 into deepmodeling:develop Sep 15, 2025
14 checks passed
@ErjieWu
ErjieWu deleted the fix branch October 11, 2025 05:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Machine Learning & AI Issues related to AI Tests/Examples Issues/PR related to unit tests and integrate tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants