Refactor: Remove obsolete cg_in_lcao code - #7870
Merged
mohanchen merged 2 commits intoAug 28, 2026
Merged
Conversation
mohanchen
approved these changes
Aug 28, 2026
Collaborator
|
We may need CG iteration solvers for LCAO codes in future. |
Collaborator
Author
Yes, we can add related code back in the future when it's fully ready. As for now, I found it sometimes very misleading, especially for coding agents (they always tell me that |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What's changed?
ks_solver=cg_in_lcaowas introduced in #3473 but was later removed in #5257. There are still some dead code, which is rather misleading. This PR aims to remove these obsoletecg_in_lcaocode.ks_solver=cg_in_lcaovalue during INPUT validation.HSolverLCAOdevice template parameter left by the old implementation.User-visible behavior
LCAO inputs using
cg_in_lcaonow fail during input validation instead of reaching unsupported or unsafe downstream paths. Supported LCAO solvers are unaffected. The generated parameter documentation is unchanged because this value was never documented as supported.