Balance the EXX q-pack timer when output is disabled - #7898
Merged
mohanchen merged 1 commit intoSep 3, 2026
Conversation
mohanchen
approved these changes
Sep 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reminder
AGENTS.mdanddocs/developers_guide/agent_governance.md.source/changes.Linked Issue
Fix #7545
Unit Tests and/or Case Tests for my changes
cmake -S . -B /tmp/abacus-build-mpi-openblascmake --build /tmp/abacus-build-mpi-openblas --target abacus_basic_para -j2cmake --build /tmp/abacus-build-mpi-openblas --target MODULE_BASE_timer -j2OMP_NUM_THREADS=1 ctest --test-dir /tmp/abacus-build-mpi-openblas --output-on-failure -R ^MODULE_BASE_timer$git diff --checkpython3 tools/03_code_analysis/agent_governance_check.py --stagedpython3 tools/03_code_analysis/agent_governance_check.py --base upstream/develop --head HEAD --format textabacus_basic_paratarget completed all 555 build steps;MODULE_BASE_timerpassed; diff checks passed. Governance emitted test-evidence and documentation reminders addressed below.opal_ifinit: socket() failed errno=1, but every compile and link step completed successfully.abacus; the configured executable target isabacus_basic_para, which subsequently built successfully.Exx_Lip::write_q_packruntime test was added because the template has no lightweight independently constructible fixture and its constructor requires the full LCAO/PW electronic-state stack. The full owning executable build instantiates the changed template, and the timer component test covers timer start/end invariants.What changed?
write_q_packtimer when charge output is disabled.Governance Notes
PARAMcheck was moved before the timer start; no global references were added..hpprationale: this PR modifies an existing template implementation header and does not add or propagate a new.hppinclude.