Skip to content

feat(pt-expt): add compact descriptor DPA4C 🎉🎉🎉 - #5972

Merged
OutisLi merged 20 commits into
deepmodeling:masterfrom
OutisLi:pr/dpa4c
Aug 18, 2026
Merged

feat(pt-expt): add compact descriptor DPA4C 🎉🎉🎉#5972
OutisLi merged 20 commits into
deepmodeling:masterfrom
OutisLi:pr/dpa4c

fix(api_cc): let a native-spin call name the charge state it wants se…

cd3fa56
Select commit
Loading
Failed to load commit list.
GitHub Advanced Security / CodeQL succeeded Aug 18, 2026 in 3s

4 new alerts

New alerts in code changed by this pull request

  • 3 warnings
  • 1 note

Alerts not introduced by this pull request might have been detected because the code changes were too large.

See annotations below for details.

View all branch alerts.

Annotations

Check warning on line 571 in deepmd/dpmodel/descriptor/dpa4c.py

See this annotation in the file changed.

Code scanning / CodeQL

Signature mismatch in overriding method Warning

This method does not accept arbitrary keyword arguments, which overridden
NativeOP.call
does.
This call
correctly calls the base method, but does not match the signature of the overriding method.
This method requires at least 4 positional arguments, whereas overridden
NativeOP.call
may be called with 1.
This call
correctly calls the base method, but does not match the signature of the overriding method.
This method requires at most 8 positional arguments, whereas overridden
NativeOP.call
may be called with arbitrarily many.
This call
correctly calls the base method, but does not match the signature of the overriding method.

Check warning on line 199 in deepmd/dpmodel/model/native_spin_model.py

See this annotation in the file changed.

Code scanning / CodeQL

Signature mismatch in overriding method Warning

This method requires at least 4 positional arguments, whereas overridden
GatedActivation.call
requires at most 3.
This call
correctly calls the base method, but does not match the signature of the overriding method.
This method requires at least 4 positional arguments, whereas overridden
GatedActivation.call
requires at most 3.
This call
correctly calls the base method, but does not match the signature of the overriding method.
This method requires at least 4 positional arguments, whereas overridden
BaseGridNet.call
requires at most 3.
This call
correctly calls the base method, but does not match the signature of the overriding method.
This method requires at least 4 positional arguments, whereas overridden
SwiGLU.call
requires 2.
This call
correctly calls the base method, but does not match the signature of the overriding method.
This method requires at least 4 positional arguments, whereas overridden
GLUFittingNet.call
requires 2.
This call
correctly calls the base method, but does not match the signature of the overriding method.
This method requires at least 4 positional arguments, whereas overridden
Identity.call
requires 2.
This call
correctly calls the base method, but does not match the signature of the overriding method.
This method requires at least 4 positional arguments, whereas overridden
make_multilayer_network.NN.call
requires 2.
This call
correctly calls the base method, but does not match the signature of the overriding method.
This method requires at least 4 positional arguments, whereas overridden
RadialMLP.call
requires 2.
This call
correctly calls the base method, but does not match the signature of the overriding method.
This method requires at least 4 positional arguments, whereas overridden
C3CutoffEnvelope.call
requires 2.
This call
correctly calls the base method, but does not match the signature of the overriding method.
This method requires at least 4 positional arguments, whereas overridden
InnerClamp.call
requires 2.
This call
correctly calls the base method, but does not match the signature of the overriding method.
This method requires at least 4 positional arguments, whereas overridden
BridgingSwitch.call
requires 2.
This call
correctly calls the base method, but does not match the signature of the overriding method.
This method requires at least 4 positional arguments, whereas overridden
SO2Linear.call
requires 2.
This call
correctly calls the base method, but does not match the signature of the overriding method.
This method requires at least 4 positional arguments, whereas overridden
test_torch_module_auto_generates_forward.MockNativeOP.call
requires 2.
This call
correctly calls the base method, but does not match the signature of the overriding method.
This method requires at least 4 positional arguments, whereas overridden
test_torch_module_auto_generates_forward_lower.MockNativeOP.call
requires 2.
This call
correctly calls the base method, but does not match the signature of the overriding method.
This method requires at least 4 positional arguments, whereas overridden
test_torch_module_respects_explicit_forward.MockNativeOP.call
requires 2.
This call
correctly calls the base method, but does not match the signature of the overriding method.
This method requires at least 4 positional arguments, whereas overridden
test_torch_module_respects_explicit_forward_lower.MockNativeOP.call
requires 2.
This call
correctly calls the base method, but does not match the signature of the overriding method.
This method requires at least 4 positional arguments, whereas overridden
test_torch_module_handles_no_call_lower_method.MockNativeOP.call
requires 2.
This call
correctly calls the base method, but does not match the signature of the overriding method.
This method requires at least 4 positional arguments, whereas overridden
WignerDCalculator.call
requires 2.
This call
correctly calls the base method, but doe

Check warning on line 322 in deepmd/pt_expt/model/native_spin_model.py

See this annotation in the file changed.

Code scanning / CodeQL

Signature mismatch in overriding method Warning

This method requires 10 positional arguments, whereas overridden
EnergyModel.forward_lower_canonical_graph_exportable
requires 9.

Check notice on line 343 in source/api_cc/src/commonPTExpt.h

See this annotation in the file changed.

Code scanning / CodeQL

Equality test on floating-point values Note

Equality checks on floating point values can yield unexpected results.