add_logit_adaptivness #23
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Samoed
reviewed
Oct 30, 2024
voorhs
reviewed
Nov 2, 2024
Collaborator
voorhs
left a comment
voorhs
left a comment
There was a problem hiding this comment.
Надо разобраться axis=0 или все таки axis=1. Мне кажется правильным второй вариант. Если это так, то надо переписать _detect_oos()
Еще ты не прогнал форматтер по коду, это нужно сделать. Команда make lint в терминале
Collaborator
Author
|
названия поменял. Теперь касательно осей и смысла метода. Я помедитировал на статью ещё раз и, соглашусь, в статье имелось в виду скалирование скоров по сэмплу, а не по классу. В связи с этим там adaptive поменялся весьма радикально (как оказалось, jinoos_adapter - это худший темплейт для adaptive_predictor) |
…v/AutoIntent into feat/logit_adaptivness
voorhs
requested changes
Nov 6, 2024
…v/AutoIntent into feat/logit_adaptivness
voorhs
approved these changes
Nov 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.