-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: integration tests for pgvector #495
base: main
Are you sure you want to change the base?
Conversation
Trivy scanning results. Report Summary ┌─────────┬──────┬─────────────────┬─────────┐
For OSS Maintainers: VEX NoticeIf you're an OSS maintainer and Trivy has detected vulnerabilities in your project that you believe are not actually exploitable, consider issuing a VEX (Vulnerability Exploitability eXchange) statement. To disable this notice, set the TRIVY_DISABLE_VEX_NOTICE environment variable. uv.lock (uv)Total: 22 (MEDIUM: 11, HIGH: 10, CRITICAL: 1) ┌──────────────────┬────────────────┬──────────┬────────┬───────────────────┬───────────────┬──────────────────────────────────────────────────────────────┐ |
pgvector integration tests can't be run with other vector stores. |
Code Coverage Summary
Diff against main
Results for commit: 29bd660 Minimum allowed coverage is ♻️ This comment has been updated with latest results |
# Conflicts: # packages/ragbits-core/CHANGELOG.md
@@ -362,7 +334,8 @@ async def retrieve( | |||
VectorStoreResult( | |||
entry=VectorStoreEntry( | |||
id=record["id"], | |||
text=record["key"], | |||
text=record["text"] or "", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is or ""
needed here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You are right, we don't need it. I removed it.
outputs.listed_entries = [ | ||
VectorStoreEntry( | ||
id=record["id"], | ||
text=record["text"] or None, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why the or None
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
removed.
# Conflicts: # packages/ragbits-core/CHANGELOG.md
No description provided.