-
Notifications
You must be signed in to change notification settings - Fork 113
feat: separate forms like/dislike + api config route #506
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Code Coverage Summary
Diff against main
Results for commit: 158a1f7 Minimum allowed coverage is ♻️ This comment has been updated with latest results |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall looks good, some minor changes from my side.
One thing that should be added to the backlog is creating a store/context with the config so that is accessible everywhere and fetched before app loads.
Regarding the enums, you can use them or create union type e.g. type FormType = ...
and object that reassembles the enum (if you don't want to use them)
539483f
to
52dabac
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's fix linters in Python code, and we can merge
Trivy scanning results. Report Summary ┌──────────────────────┬──────┬─────────────────┬─────────┐
For OSS Maintainers: VEX NoticeIf you're an OSS maintainer and Trivy has detected vulnerabilities in your project that you believe are not actually exploitable, consider issuing a VEX (Vulnerability Exploitability eXchange) statement. To disable this notice, set the TRIVY_DISABLE_VEX_NOTICE environment variable. ui/package-lock.json (npm)Total: 1 (MEDIUM: 1, HIGH: 0, CRITICAL: 0) ┌────────────────┬────────────────┬──────────┬────────┬───────────────────┬─────────────────────────┬─────────────────────────────────────────────────────────────┐ uv.lock (uv)Total: 22 (MEDIUM: 11, HIGH: 10, CRITICAL: 1) ┌──────────────────┬────────────────┬──────────┬────────┬───────────────────┬───────────────┬──────────────────────────────────────────────────────────────┐ |
No description provided.