Skip to content

Conversation

@anakin87
Copy link
Member

@anakin87 anakin87 commented Jan 13, 2026

Related Issues

I could not release Weave because our version validation script is (correctly) strict and this integration does not respect standards. https://github.com/deepset-ai/haystack-core-integrations/actions/runs/20953760442/job/60213236607

Proposed Changes:

  • standardize Weave integration (move, rename...)

How did you test it?

CI

Notes for the reviewer

This change is just about the repo structure. Does not affect users.

Checklist

@github-actions github-actions bot added topic:CI integration:weave components coming from Weights and Biases labels Jan 13, 2026
@anakin87 anakin87 marked this pull request as ready for review January 13, 2026 11:10
@anakin87 anakin87 requested a review from a team as a code owner January 13, 2026 11:10
@anakin87 anakin87 requested review from sjrl and removed request for a team January 13, 2026 11:10
@davidsbatista
Copy link
Contributor

out of curiosity: was the issue related to the underscore in the integration name?

@anakin87
Copy link
Member Author

out of curiosity: was the issue related to the underscore in the integration name?

no, about the fact that the package is weave-haystack while the folder name is weights_and_biases_weave

Copy link
Contributor

@davidsbatista davidsbatista left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@anakin87 anakin87 merged commit 3ab89df into main Jan 13, 2026
11 checks passed
@anakin87 anakin87 deleted the move-weave branch January 13, 2026 11:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

integration:weave components coming from Weights and Biases topic:CI

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants