Skip to content

Conversation

@davidsbatista
Copy link
Contributor

@davidsbatista davidsbatista commented Jan 13, 2026

Proposed Changes:

How did you test it?

  • added integration tests
  • manual verification

Checklist

davidsbatista and others added 30 commits January 5, 2026 15:17
…res/opensearch/document_store.py

Co-authored-by: Sebastian Husch Lee <[email protected]>
…res/opensearch/document_store.py

Co-authored-by: Sebastian Husch Lee <[email protected]>
davidsbatista and others added 14 commits January 13, 2026 14:22
…res/opensearch/document_store.py

Co-authored-by: Sebastian Husch Lee <[email protected]>
…res/opensearch/document_store.py

Co-authored-by: Sebastian Husch Lee <[email protected]>
…res/opensearch/document_store.py

Co-authored-by: Sebastian Husch Lee <[email protected]>
…res/opensearch/document_store.py

Co-authored-by: Sebastian Husch Lee <[email protected]>
…res/opensearch/document_store.py

Co-authored-by: Sebastian Husch Lee <[email protected]>
…res/opensearch/document_store.py

Co-authored-by: Sebastian Husch Lee <[email protected]>
…res/opensearch/document_store.py

Co-authored-by: Sebastian Husch Lee <[email protected]>
…res/opensearch/document_store.py

Co-authored-by: Sebastian Husch Lee <[email protected]>
…res/opensearch/document_store.py

Co-authored-by: Sebastian Husch Lee <[email protected]>
@davidsbatista davidsbatista changed the title feat: add SQLRetriever to OpenSearchDocumentStore feat: add an SQLRetriever to OpenSearchDocumentStore Jan 16, 2026
@davidsbatista
Copy link
Contributor Author

@tstadel @sjrl regarding the ResponseFormat for the SQLRetriever, as discussed before, I think it's better to stick with one simple format - I suggest JSON - and drop the others. Makes the code simpler.

WDYT?

@davidsbatista davidsbatista marked this pull request as ready for review January 16, 2026 14:34
@davidsbatista davidsbatista requested a review from a team as a code owner January 16, 2026 14:34
@davidsbatista davidsbatista requested review from anakin87, sjrl and tstadel and removed request for a team and anakin87 January 16, 2026 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

integration:opensearch type:documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants