Skip to content

Conversation

@sjrl
Copy link
Contributor

@sjrl sjrl commented Jan 14, 2026

Related Issues

Proposed Changes:

  • Update Generator and ChatGenerator to auto call run warm_up
  • Add missing license headers

How did you test it?

Existing tests

Notes for the reviewer

Checklist

@sjrl sjrl requested a review from a team as a code owner January 14, 2026 10:50
@sjrl sjrl requested review from julian-risch and removed request for a team January 14, 2026 10:50
@sjrl sjrl self-assigned this Jan 14, 2026
@github-actions github-actions bot added integration:llama_cpp type:documentation Improvements or additions to documentation labels Jan 14, 2026
Copy link
Member

@julian-risch julian-risch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggest we remove the explicit warm_up() call from where it is no longer needed. Other than that there only seem to be a few linter errors. Otherwise looks good to me!

@sjrl sjrl requested a review from julian-risch January 14, 2026 11:24
@sjrl sjrl merged commit ddc195c into main Jan 14, 2026
10 checks passed
@sjrl sjrl deleted the auto-warm-up-llama-cpp branch January 14, 2026 12:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

integration:llama_cpp type:documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants