Skip to content

Conversation

@sjrl
Copy link
Contributor

@sjrl sjrl commented Jan 14, 2026

Related Issues

Proposed Changes:

  • Update the splitter to auto call run warm_up

How did you test it?

Updated existing tests

Notes for the reviewer

Checklist

@sjrl sjrl requested a review from a team as a code owner January 14, 2026 12:27
@sjrl sjrl requested review from julian-risch and removed request for a team January 14, 2026 12:27
@sjrl sjrl self-assigned this Jan 14, 2026
Copy link
Member

@julian-risch julian-risch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! 👍 Let's not forget to simplify the code example in the integration page: https://haystack.deepset.ai/integrations/hanlp and the documentation page https://docs.haystack.deepset.ai/docs/chinesedocumentsplitter
Maybe we could have one GitHub issue as a reminder to go through all the integrations that you updates? As a separate follow up to #2592 not as another step of that issue.

@github-actions github-actions bot added the type:documentation Improvements or additions to documentation label Jan 14, 2026
@sjrl
Copy link
Contributor Author

sjrl commented Jan 14, 2026

Looks good to me! 👍 Let's not forget to simplify the code example in the integration page: https://haystack.deepset.ai/integrations/hanlp and the documentation page https://docs.haystack.deepset.ai/docs/chinesedocumentsplitter Maybe we could have one GitHub issue as a reminder to go through all the integrations that you updates? As a separate follow up to #2592 not as another step of that issue.

Sounds good! Made a new issue here #2751

@sjrl sjrl merged commit 4a6f2f8 into main Jan 14, 2026
8 checks passed
@sjrl sjrl deleted the auto-warm-up-hanlp branch January 14, 2026 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

integration:hanlp type:documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants