fix: CometAPIChatGenerator - handle delta set to None
#2759
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
integration:cometapi
type:documentation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issues
Twin PR of deepset-ai/haystack#10397
Proposed Changes:
deltaset toNoneduring streamingHow did you test it?
Unfortunately cannot reproduce the issue now.
Tested in Haystack, so I am not adding tests here.
Notes for the reviewer
I'll create an issue to remove this monkey patch after Haystack 2.23.0. -> #2760
Checklist
fix:,feat:,build:,chore:,ci:,docs:,style:,refactor:,perf:,test:.