Conversation
Contributor
Contributor
|
Looks good to me, seems that the comment posted on PRs will exclude integration test coverage? Is the reason that some community members PR don't run the integration tests? |
davidsbatista
approved these changes
Mar 31, 2026
davidsbatista
left a comment
Contributor
There was a problem hiding this comment.
LGTM - just a question/curiosity
Member
Author
We don't expose API keys on PRs running from forks for security reasons. So, in this case, integration tests requiring API keys are skipped and combined coverage cannot be computed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issues
We want to start tracking test coverage and add comments on PRs with this info.
Ideally, we want to track unit test coverage, but also secondarily keep track of combined test coverage (for some integrations like Document Stores, most tests are integration tests).
We would also like to avoid relying on hosted tools.
I have investigated several options involving GitHub actions, but I finally chose https://github.com/py-cov-action/python-coverage-comment-action for its ability to show positive or negative variations of test coverage natively.
Proposed Changes:
This is a pilot, so I am just introducing this change for the Kreuzberg integration.
Result should look like this:
How did you test it?
I tried this extensively on my fork. See for example anakin87#5

Checklist
fix:,feat:,build:,chore:,ci:,docs:,style:,refactor:,perf:,test:.