Skip to content

Conversation

@davidsbatista
Copy link
Contributor

@davidsbatista davidsbatista commented Nov 24, 2025

Related Issues

Proposed Changes:

  • Adding 3 new components from experimental:
    • QueryExpander
    • MultiQueryEmbeddingRetriever
    • MultiQueryTextRetriever

How did you test it?

  • unit tests, integration tests + CI

Checklist

  • I have read the contributors guidelines and the code of conduct.
  • I have updated the related issue with new insights and changes.
  • I have added unit tests and updated the docstrings.
  • I've used one of the conventional commit types for my PR title: fix:, feat:, build:, chore:, ci:, docs:, style:, refactor:, perf:, test: and added ! in case the PR includes breaking changes.
  • I have documented my code.
  • I have added a release note file, following the contributors guidelines.
  • I have run pre-commit hooks and fixed any issue.

@vercel
Copy link

vercel bot commented Nov 24, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Preview Comments Updated (UTC)
haystack-docs Ignored Ignored Preview Nov 24, 2025 3:52pm

@github-actions github-actions bot added topic:tests type:documentation Improvements on the docs labels Nov 24, 2025
@coveralls
Copy link
Collaborator

coveralls commented Nov 24, 2025

Pull Request Test Coverage Report for Build 19640435406

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 3 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+0.1%) to 91.539%

Files with Coverage Reduction New Missed Lines %
core/pipeline/async_pipeline.py 3 65.88%
Totals Coverage Status
Change from base Build 19637726908: 0.1%
Covered Lines: 13913
Relevant Lines: 15199

💛 - Coveralls

@davidsbatista davidsbatista changed the title Feat/adding query expander multi query retriever feat: adding QueryExpander, MultiQueryEmbeddingRetriever and MultiQueryTextRetriever Nov 24, 2025
@davidsbatista davidsbatista marked this pull request as ready for review November 24, 2025 14:05
@davidsbatista davidsbatista requested a review from a team as a code owner November 24, 2025 14:05
@davidsbatista davidsbatista requested review from Amnah199 and removed request for a team November 24, 2025 14:05
Copy link
Member

@anakin87 anakin87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left some minor comments.

Let's also try to increase the coverage of these new components with unit tests. The coveralls report can help.

Copy link
Member

@anakin87 anakin87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

Please also create a new issue to track the creation of documentation pages for these new components.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Migrate QueryExpander, MultiQueryTextRetriever and MultiQueryEmbeddingRetriever from haystack-experimental to haystack

4 participants