-
Notifications
You must be signed in to change notification settings - Fork 2.5k
feat: adding QueryExpander, MultiQueryEmbeddingRetriever and MultiQueryTextRetriever
#10126
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
feat: adding QueryExpander, MultiQueryEmbeddingRetriever and MultiQueryTextRetriever
#10126
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
Pull Request Test Coverage Report for Build 19640435406Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
QueryExpander, MultiQueryEmbeddingRetriever and MultiQueryTextRetriever
anakin87
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left some minor comments.
Let's also try to increase the coverage of these new components with unit tests. The coveralls report can help.
haystack/components/retrievers/multi_query_embedding_retriever.py
Outdated
Show resolved
Hide resolved
releasenotes/notes/adding-QueryExpander-MultiQueryRetriever-88c4847894ea1fd0.yaml
Outdated
Show resolved
Hide resolved
Co-authored-by: Stefano Fiorucci <[email protected]>
Co-authored-by: Stefano Fiorucci <[email protected]>
…c4847894ea1fd0.yaml Co-authored-by: Stefano Fiorucci <[email protected]>
anakin87
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
Please also create a new issue to track the creation of documentation pages for these new components.
Related Issues
QueryExpander,MultiQueryTextRetrieverandMultiQueryEmbeddingRetrieverfromhaystack-experimentaltohaystack#10086Proposed Changes:
QueryExpanderMultiQueryEmbeddingRetrieverMultiQueryTextRetrieverHow did you test it?
Checklist
fix:,feat:,build:,chore:,ci:,docs:,style:,refactor:,perf:,test:and added!in case the PR includes breaking changes.