fix: pagination error too many values to unpack - #11475
Merged
Merged
Conversation
expand_page_range() called page.split("-") without maxsplit, then
unpacked into exactly two variables. A range string like "5-10-15"
produced "too many values to unpack" instead of a useful error message.
Add maxsplit=1 and validate that both parts are digit strings before
expanding the range, raising a descriptive ValueError for malformed input.
Fixes #11449
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
Contributor
Coverage report
Click to see where and how coverage changed
This report was generated by python-coverage-comment-action |
||||||||||||||||||||||||
Code reviewNo issues found. Checked for bugs and CLAUDE.md compliance. |
sjrl
reviewed
Jun 2, 2026
sjrl
reviewed
Jun 2, 2026
sjrl
reviewed
Jun 2, 2026
sjrl
reviewed
Jun 2, 2026
| assert kwargs["keys"] == ["key1"] | ||
|
|
||
|
|
||
| class TestExpandPageRange: |
Contributor
There was a problem hiding this comment.
Huh I didn't realize this is the first unit test we have for this function. Could we add a few more to cover standard use cases?
Co-authored-by: Sebastian Husch Lee <10526848+sjrl@users.noreply.github.com>
Co-authored-by: Sebastian Husch Lee <10526848+sjrl@users.noreply.github.com>
davidsbatista
enabled auto-merge (squash)
June 2, 2026 09:32
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Closes #11449
Proposed Changes:
expand_page_range()in haystack/utils/misc.py crashes with ValueError: too many values to unpack (expected 2) when any element of the input list contains more than one hyphen, e.g. "5-10-15".How did you test it?
Notes for the reviewer
Checklist
fix:,feat:,build:,chore:,ci:,docs:,style:,refactor:,perf:,test:and added!in case the PR includes breaking changes.