fix: better error message for llm metadata extractor - #11477
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
Coverage report
Click to see where and how coverage changed
This report was generated by python-coverage-comment-action |
||||||||||||||||||||||||
Code reviewNo issues found. Checked for bugs and CLAUDE.md compliance. |
davidsbatista
approved these changes
Jun 2, 2026
davidsbatista
left a comment
davidsbatista
left a comment
Contributor
There was a problem hiding this comment.
Looks good.
I can't see where the IndexError was removed; through the diff, it's still a ValueError as before, only the test condition and the message changed.
sjrl
commented
Jun 2, 2026
| ast = SandboxedEnvironment().parse(prompt) | ||
| template_variables = meta.find_undeclared_variables(ast) | ||
| variables = list(template_variables) | ||
| if len(variables) > 1 or variables[0] != "document": |
Contributor
Author
There was a problem hiding this comment.
this line caused the index error variables[0] since it assumes variables has at least one item in it
Contributor
There was a problem hiding this comment.
ah got it now! 👍🏽 thanks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issues
Proposed Changes:
Fixes the error message raised by the
LLMMetadataExtractor. Previously it would raise anIndexErrorwhen trying to raise theValueErrorsince we assumed the number of variables in the prompt would be non-zero.How did you test it?
Added new unit tests.
Notes for the reviewer
Checklist
fix:,feat:,build:,chore:,ci:,docs:,style:,refactor:,perf:,test:and added!in case the PR includes breaking changes.