You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Hi @zcxGGmu, thanks a lot for your contribution! 🙏
We noticed that the Contributor License Agreement (CLA) check (license/cla) hasn't passed yet, so we've temporarily moved this PR to draft and paused the review assignment.
To get your PR reviewed, please sign the CLA via the link in the license/cla check below (or in the CLA bot comment). As soon as the check turns green, this PR will automatically be marked ready for review again and a reviewer will be re-assigned.
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution. You have signed the CLA already but the status is still pending? Let us recheck it.
Hi @zcxGGmu, just a friendly reminder: this PR is still in draft because the Contributor License Agreement (CLA) hasn't been signed yet. We'd love to review your contribution! Please sign the CLA via the link in the license/cla check, and this PR will automatically be marked ready for review.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
link_formattoPyPDFToDocumentandPDFMinerToDocumentwithmarkdown,plain, andnonemodes.link_format="none".Fixes #10677
Testing
hatch -e test run pytest test/components/converters/test_pypdf_to_document.py test/components/converters/test_pdfminer_to_document.pyhatch -e test run mypy --python-version 3.13 --install-types --non-interactive --cache-dir=.mypy_cache/ haystack/components/converters/utils.py haystack/components/converters/pypdf.py haystack/components/converters/pdfminer.pyhatch run fmt-check haystack/components/converters/utils.py haystack/components/converters/pypdf.py haystack/components/converters/pdfminer.py test/components/converters/test_pypdf_to_document.py test/components/converters/test_pdfminer_to_document.pygit diff --check